Repository navigation
ci: use the chart-owners branch of the charts action - #2654
Draft
nicholasSUSE wants to merge 1 commit into
Draft
nicholasSUSE wants to merge 1 commit into
nicholasSUSE wants to merge 1 commit into
Conversation
This workflow called the ship action of rancher/charts at a fixed commit. That commit is from before the check that every image of the chart is in the staging registry before the chart is pushed, so releases from this repository did not run it. The call now uses the chart-owners branch, which carries the checks, and a comment above it asks to keep it there and not to pin a commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This changes the
rancher/chartsship action from a fixed commit to thechart-ownersbranch, and adds a short comment asking to keep it there.The commit that was pinned is from before the check that every image of the chart is in the staging registry before the chart is pushed (rancher/charts#9546), so a release from this repository would not run it. Several charts were staged recently with images that were missing from staging, which is what the check prevents.
The next release from this repository will run the check. If an image of the chart is not in
stgregistry.suse.com, the job stops before it pushes anything, and the log names the missing images. Please push the images first, then run it again.Questions are welcome, I'm happy to help.